fix: handle :MISSION:SAVED: async callback from extension#114
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request transitions the mission saving and uploading process to be asynchronous. It introduces a new :MISSION:SAVED: callback handler in fnc_initSession.sqf to process results and notify users, while updating fnc_exportData.sqf to queue the save and provide an interim status. Feedback suggests adding type validation to the callback data parsing to prevent script errors and updating the diary record creation to reflect the asynchronous nature of the save process, as the current wording remains prematurely optimistic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:MISSION:SAVED:branch to the existingExtensionCallbackhandler that surfaces the final save/upload result to players.fnc_exportData.sqf.Why
When paired with OCAP2/extension#159,
:MISSION:SAVE:returnsqueuedimmediately and fires:MISSION:SAVED:later with one ofok,partial, orerror. This PR teaches the addon to handle those callbacks and surface the final state to players via CBA notifications.Without this change the addon still works (the callback is silently ignored), but players see "OCAP saving..." and never learn whether upload succeeded.
Test plan